code hygiene: rename validateEnabled to validateEnabledType
#2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
seantking,
colin-axner,
AdityaSripal and
damiannolan
as code owners
3 tasks
damiannolan
approved these changes
Oct 5, 2022
colin-axner
approved these changes
Oct 5, 2022
| } | ||
| } | ||
|
|
||
| func validateEnabled(i interface{}) error { | ||
| func validateEnabledType(i interface{}) error { |
There was a problem hiding this comment.
fwiw, we can remove these functions when we self manage params
…ccountscontrollertypes-paramsvalidate-suspiciously-performs-no-checks-yet-unnecessary-conversions-from-bool-to-interface-then-checks-if-value-is-a-bool-and-not-if-it-is-enabled
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2469 +/- ##
=======================================
Coverage 78.70% 78.70%
=======================================
Files 178 178
Lines 12311 12311
=======================================
Hits 9689 9689
Misses 2195 2195
Partials 427 427
|
added 2 commits
October 5, 2022 22:23
…ccountscontrollertypes-paramsvalidate-suspiciously-performs-no-checks-yet-unnecessary-conversions-from-bool-to-interface-then-checks-if-value-is-a-bool-and-not-if-it-is-enabled
…ccountscontrollertypes-paramsvalidate-suspiciously-performs-no-checks-yet-unnecessary-conversions-from-bool-to-interface-then-checks-if-value-is-a-bool-and-not-if-it-is-enabled
crodriguezvega
deleted the
carlos/issue#2266-modulesapps27-interchain-accountscontrollertypes-paramsvalidate-suspiciously-performs-no-checks-yet-unnecessary-conversions-from-bool-to-interface-then-checks-if-value-is-a-bool-and-not-if-it-is-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #2266
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes